Conversation
…PostgresSQL extensions
dliakhov
requested review from
JiriCtvrtka and
idoqo
and removed request for
a team
BupycHuk
reviewed
May 4, 2023
Comment on lines
301
to
302
Contributor
There was a problem hiding this comment.
not sure if we need to collect service_name, it might contain personal data
Codecov Report
@@ Coverage Diff @@
## main #2083 +/- ##
==========================================
- Coverage 42.63% 42.56% -0.07%
==========================================
Files 387 387
Lines 47651 47494 -157
==========================================
- Hits 20315 20217 -98
+ Misses 25430 25371 -59
Partials 1906 1906
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 30 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
0leksii
approved these changes
May 5, 2023
BupycHuk
approved these changes
May 6, 2023
ritbl
approved these changes
May 8, 2023
dliakhov
deleted the
PMM-11984-add-datapoints-to-show-installed-and-available-postgressql-extensions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the scope of this PR were created two datapoints which send data about installed and available PostgresSQL extensions of the connected databases.
PMM-11984
Link to the Feature Build: Percona-Lab/pmm-submodules#3258
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: